Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for multiple issues #156

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Fixes for multiple issues #156

merged 4 commits into from
Nov 27, 2023

Conversation

Walter-00
Copy link
Contributor

Overview

The purpose of this request it to fix 4 of the open issues.

Details

This should fix the following issues:
#154
#121
#48
#140

Testing Steps

Just go into the issues and try to see if you still get the error. I couldn't replicate everything, but I could see the code that should be causing it, so I implemented fixes. If you're able to replicate it, please do test before merging.

I did partially test what I could replicate, the script still appears to work fine. And I didn't test it in multiplayer, since I don't believe I've made any changes that shouldn't work in multiplayer. Feel free to test everything though, I'd appreciate that!

  • [~] Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • [-] Did you test your changes in multiplayer to ensure it works correctly on all clients?

@B0STRA
Copy link
Contributor

B0STRA commented Nov 26, 2023

Fixes #121 #154 #140 Confirmed. Unable to test #48 at this time.

@MonkeyWhisper
Copy link
Member

Tested #48 works great!

Thanks for PR

@MonkeyWhisper MonkeyWhisper merged commit 675dea1 into Project-Sloth:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants